Fix completion of '%tim' in the Qt console - #1972
Closed
takluyver wants to merge 1 commit into
Closed
Conversation
Member
There was a problem hiding this comment.
I guess first you want the other way around, set True as default, and False if the typed text contains %#\.....
works better : ti<tab> -> time but then it fails if you do %<tab> where it fastforward to %%
Member
Author
There was a problem hiding this comment.
The other thing to try is pd<tab> - in a clean kernel, the only things starting with pd are magic functions, so it should replace it with %pd. I think it will get this wrong if you switch True/False.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From discussion on #1944, this is my attempt at the same fix using regexes.
I'm not yet entirely happy with this - e.g. if you type
tim<TAB>without an escape sequence, it still gives you%as the common prefix of the matches. But I'm too tired to work it all out at the moment. Other eyes are welcome, or I'll pick it up in the morning.