Disable emacs_bindings_in_vi_insert_mode by default - #15327
Open
vlcpenguin wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider disabling emacs_bindings_in_vi_insert_mode by default. It delays entering normal mode. And if you forget to wait or double-tap ESC and press H, J, K, or L, it goes back or forward in history or deletes everything before or after your cursor, which makes the VI mode completely useless for the average VI enjoyer and causes unnecessary confusion. I am not sure if this behavior is intended. Users have expressed this in past issues as well, so I recommend just turning it off by default while keeping it as an option in the IPython config file.
As of now it just degrades the experience with VI mode on IPython.