fix: don't let kitty graphics detection crash IPython startup#15264
Open
chrisburr wants to merge 1 commit into
Open
fix: don't let kitty graphics detection crash IPython startup#15264chrisburr wants to merge 1 commit into
chrisburr wants to merge 1 commit into
Conversation
_supports_kitty_graphics() walks the process tree with psutil at import time to detect a graphics-capable terminal. On shared multi-user systems where /proc is mounted with hidepid (common on HPC clusters), reaching an ancestor process owned by another user raises psutil.AccessDenied, which was unhandled and aborted the entire `import IPython`. Catch psutil/OS errors during the walk and treat them as "graphics unsupported" instead. A real supported terminal is one of the user's own near ancestors and is found before any restricted PID, so detection capability is unchanged.
|
test |
|
Thank you! Tested on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_supports_kitty_graphics()walks the process tree withpsutilat import time to detect a graphics-capable terminal. On shared multi-user systems where/procis mounted withhidepid(common on HPC clusters), reaching an ancestor process owned by another user raisespsutil.AccessDenied, which was unhandled and aborted the entireimport IPython:Catch errors during the walk and treat them as "graphics unsupported" instead. A real supported terminal is one of the user's own near ancestors and is found before any restricted PID, so detection capability is unchanged.