Fix doctest prompt stripping regression#15260
Open
Erotemic wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15259
A regression in IPython 9.10 caused doctest prompts (
>>>or...) to stop being stripped in multiline strings.The change in the regex from
\sto[ \t]prevents it from eating newlines for "blank lines" (i.e. a bare...).The new code add checks when the stripper encounts a multiline string and strips leading PS1/PS2 prompts if they agree with the indentation of outer stripped prompts. This should be safe and real
>>>or...inside a multiline string should be preserved (CLASSIC_PROMPT_INDENTED_LITERAL_MULTILINE_STRINGtests this).