Skip to content

Fix Python 3.12+ test failures in drop-3.11 PR #15125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 6 commits into from
Closed

Fix Python 3.12+ test failures in drop-3.11 PR #15125

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7eae589
Initial plan
Copilot Feb 10, 2026
68ec249
Fix test failures for Python 3.15 compatibility
Copilot Feb 10, 2026
ee959c6
Fix test_pretty_environ to handle both Python 3.12 repr formats
Copilot Feb 10, 2026
362204b
Improve test_pretty_environ comments for clarity
Copilot Feb 10, 2026
3d2fc3c
Fix os.environ pretty-printing with deferred printer registration
Copilot Feb 11, 2026
acbcb34
Address code review feedback - remove variable shadowing and extra bl…
Copilot Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Address code review feedback - remove variable shadowing and extra bl… 
…ank line

Co-authored-by: Carreau <335567+Carreau@users.noreply.github.com>
  • Loading branch information
@Carreau
Copilot and Carreau committed Feb 11, 2026
commit acbcb347c0b066f975c042b4fa3fc80e270bcc68
4 changes: 1 addition & 3 deletions IPython/lib/pretty.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -859,7 +859,6 @@ def _exception_pprint(obj, p, cycle):
if _env_type is not dict:
_type_pprinters[_env_type] = _dict_pprinter_factory('environ{', '}')


_type_pprinters[types.MappingProxyType] = _dict_pprinter_factory("mappingproxy({", "})")
_type_pprinters[slice] = _repr_pprint

Expand All @@ -871,8 +870,7 @@ def _exception_pprint(obj, p, cycle):

# Also register os._Environ as deferred printer to handle module reloading scenarios
# (e.g., in test environments). This uses module+name lookup rather than type identity.
_env_type = type(os.environ)
if _env_type is not dict:
if type(os.environ) is not dict:
_deferred_type_pprinters[('os', '_Environ')] = _dict_pprinter_factory('environ{', '}')


Expand Down