Skip to content

Fix re pattern pretty print#14559

Merged
Carreau merged 2 commits into
ipython:mainfrom
wimglenn:patch-2
Oct 25, 2024
Merged

Fix re pattern pretty print#14559
Carreau merged 2 commits into
ipython:mainfrom
wimglenn:patch-2

Conversation

@wimglenn

Copy link
Copy Markdown
Contributor

Alternative to #14558

@Carreau

Carreau commented Oct 25, 2024

Copy link
Copy Markdown
Member

Thanks, I prefer this one.

The other one contains code that is specifically to be compatible between multiple versions, but it's hard to know later on the , 0 and TEMPLATE could be removed once we drop 3.12, so I leaning toward hanging formatting, worse case we revert.

@Carreau Carreau added this to the 8.29 milestone Oct 25, 2024
@Carreau
Carreau merged commit de562f8 into ipython:main Oct 25, 2024
@wimglenn
wimglenn deleted the patch-2 branch October 25, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants