Skip to content

Autobalance #14081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jb-leger wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Autobalance #14081

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2f5286e
Pass the shell instance to the TransformerManager
jb-leger May 19, 2023
95fc928
Pass the shell and display indication from the TransformerManager to …
jb-leger May 19, 2023
86e13a0
Add tranformation for autobalance [{()}]
jb-leger May 19, 2023
eef46e8
define magic for controlling autobalance
jb-leger May 19, 2023
10f3017
use typing.TYPE_CHECKING to prevent import
jb-leger Jun 12, 2023
79a23bf
autobalance: use callable class to store the shell and do not use kwargs
jb-leger Jun 12, 2023
b3c3de5
autobalance: make AutoBalancer usable without shell with default beha…
jb-leger Jun 12, 2023
1630c25
autobalance: add tests
jb-leger Jun 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
autobalance: make AutoBalancer usable without shell with default beha… 
…vior
  • Loading branch information
@jb-leger
jb-leger committed Jun 12, 2023
commit b3c3de54fe2f5e1df82b1a30598b284a53921192
11 changes: 8 additions & 3 deletions IPython/core/inputtransformer2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,8 +241,9 @@ class AutoBalancer:

has_side_effects: bool = True

def __init__(self, shell):
def __init__(self, shell=None, default=False):
self._shell = shell
self._default = default

def __call__(self, lines):
"""For single line cell, add necessary [{( and )}] to balance."""
Expand All @@ -251,12 +252,16 @@ def __call__(self, lines):
# apply only for single line cell
return lines

if self._shell is None or not self._shell.autobalance:
if self._shell is None:
if not self._default:
return lines
elif not self._shell.autobalance:
return lines

modified, new_line = _autobalance_line(lines[0])
if modified:
self._shell.auto_rewrite_input(new_line)
if self._shell is not None:
self._shell.auto_rewrite_input(new_line)
return [new_line]
return lines

Expand Down