docs(breaking): add breaking changes for v5#20156
Merged
Merged
Conversation
liamdebeasi
reviewed
Jan 8, 2020
Co-Authored-By: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
Co-Authored-By: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
Co-Authored-By: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just to add the breaking changes for v5 to a file that we can link to. They can still be listed in the changelog, but this is a more comprehensive overview of what's changed.
Spoke with Ben and Kevin, we're going to move the ionicons list to the ionicons repo and link to that.