Skip to content

fix(menu): clamp out of bounds swipe value#19684

Merged
liamdebeasi merged 1 commit into
masterfrom
menu-progression
Oct 18, 2019
Merged

fix(menu): clamp out of bounds swipe value#19684
liamdebeasi merged 1 commit into
masterfrom
menu-progression

Conversation

@liamdebeasi

@liamdebeasi liamdebeasi commented Oct 17, 2019

Copy link
Copy Markdown
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #18927

What is the new behavior?

  • The cubic bezier curve for the sidemenu does not allow progressions of >1 or <0, so we clamped the value to between that range.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot Bot added the package: core @ionic/core package label Oct 17, 2019
@liamdebeasi liamdebeasi merged commit e323300 into master Oct 18, 2019
@liamdebeasi liamdebeasi deleted the menu-progression branch October 18, 2019 12:56
liamdebeasi added a commit that referenced this pull request Oct 21, 2019
elylucas pushed a commit that referenced this pull request Nov 7, 2019
elylucas pushed a commit that referenced this pull request Nov 7, 2019
elylucas pushed a commit that referenced this pull request Dec 11, 2019
elylucas pushed a commit that referenced this pull request Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant