Skip to content

chore(tests): update tests and add e2e to ci#19637

Merged
brandyscarney merged 4 commits into
masterfrom
chore-e2e-tests-failing
Oct 11, 2019
Merged

chore(tests): update tests and add e2e to ci#19637
brandyscarney merged 4 commits into
masterfrom
chore-e2e-tests-failing

Conversation

@brandyscarney

Copy link
Copy Markdown
Member

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot Bot added the package: core @ionic/core package label Oct 11, 2019
@brandyscarney brandyscarney merged commit 981cb56 into master Oct 11, 2019
@brandyscarney brandyscarney deleted the chore-e2e-tests-failing branch October 11, 2019 20:51
elylucas pushed a commit that referenced this pull request Oct 30, 2019
- increase timeout to fix failing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant