Skip to content

fix(searchbar): respect back button config value#19353

Merged
brandyscarney merged 8 commits into
ionic-team:masterfrom
masimplo:fix/searchbarConfigIcon-
Oct 16, 2019
Merged

fix(searchbar): respect back button config value#19353
brandyscarney merged 8 commits into
ionic-team:masterfrom
masimplo:fix/searchbarConfigIcon-

Conversation

@masimplo

Copy link
Copy Markdown
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #19347 19347

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot Bot added the package: core @ionic/core package label Sep 16, 2019
Comment thread core/src/components/searchbar/searchbar.tsx Outdated
@brandyscarney brandyscarney merged commit ed6f3b9 into ionic-team:master Oct 16, 2019
@masimplo masimplo deleted the fix/searchbarConfigIcon- branch October 17, 2019 08:00
elylucas pushed a commit that referenced this pull request Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants