fix(card) Fixes the ion-card color issue #19197#19216
Closed
domske wants to merge 3 commits into
Closed
Conversation
Contributor
|
Thanks for helping to debug this! In the next major release of i'll we're going to be converting card to shadow dom, which should help solve this issue. #19395 Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
The
ion-card-headerdoes not take the color of theion-card.It's because the
ion-card-headerhas a background and uses the variableion-item-background.Please see the issue for detailed description and demonstrations.
Issue Number: #19197
What is the new behavior?
Now the
ion-card-header (and other card elements) takes the background color.See
ion-card-header.scssandion-card.scssand the test demoitem-color.In this demo the css variable
--ion-item-backgroundis set and important for this issue.Does this introduce a breaking change?