feat(col): new order property#18805
Closed
marcjulian wants to merge 9 commits into
Closed
Conversation
Contributor
Author
|
@brandyscarney any feedback on this PR? |
Contributor
|
Thank you for the PR! We appreciate your contribution to Ionic. After discussing with the team, we have decided this is not the direction we want to take with this feature. While we see the value in customizing the order of the columns based on breakpoints, we do not think that adding a property for each breakpoint is the correct approach. We would likely want to do more research as to the preferred approach, but for now we are unable to accept this PR. If you still wish to see this feature get added to Ionic, we recommend creating a new feature request and providing a use case. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
A grid has 3 columns and they are all displayed in the same order on each screen size. The second column is very important so it is in the middle on larger screens and it should be on the top, reordered, on smaller screens. The reordering is currently not supported
What is the new behavior?
firstandlastpositionDoes this introduce a breaking change?
Other information