Bugfix/ion tabs query params#18740
Closed
mobregozo wants to merge 12 commits into
Closed
Conversation
13 tasks
Contributor
|
Thanks for the PR! We appreciate the work that went into this. My only concern about this PR is that it explicitly adds the query params. Are things like fragments going to be lost by making this change? There is also #18493 which attempts to fix the same issue. Perhaps we can find some solution between the two PRs? |
Author
|
hey @liamdebeasi thanks for the feedback! |
Contributor
|
Thanks for the PR! We appreciate all the time and hard work you put into developing this. We have decided to merge another PR that fixes the same issue (#18493), so I will be closing this one. The fix will be available in an upcoming release of Ionic Framework. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
When navigating between tabs and one of the views of the tabs has query params in its URL, the query params are lost when navigating back to that particular Tab.
Issue Number: 18717
What is the new behavior?
When navigating between tabs and one of the views of the tabs has query params in its URL, the query params are still present when navigating back to that particular Tab.
Does this introduce a breaking change?