feat(menu): default overlay for all platforms#18562
Closed
mlynch wants to merge 1 commit into
Closed
Conversation
Member
|
Do we have any guidelines we can refer to for iOS? |
Contributor
|
#19063 😬 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the default for menu to be
overlayon all platforms.I've been working with Ben and we both agree that the overlay style is much more prevalent these days for apps on Android and iOS, and looks quite a bit more sophisticated than the reveal type which we'd like to phase out.
I suppose this would be a breaking change, need to think about the details there. Since we're going to update the starters to set the type explicitly to
overlay, perhaps we can come up with a plan to introduce the changes in this PR at a specific later date? Perhaps in line with our upcoming title/menu/etc. changes for iOS 13 and Ionic 5?