feat(select): Allow select options in popover to be individually styl…#17305
Closed
audaxion wants to merge 90 commits into
Closed
feat(select): Allow select options in popover to be individually styl…#17305audaxion wants to merge 90 commits into
audaxion wants to merge 90 commits into
Conversation
Member
|
Thank you for the PR! This looks great, but would it possible to instead grab the class and pass it? Like the following: I'll have to look into this more but wanted to comment first. 🙂 |
…eable. Update property to be named 'class' instead of 'cssClass' per comments
Contributor
Author
|
I like that suggestion. I've updated the PR to use class instead of the new property cssClass. |
…eable. Update angular files -- fix from merge
brandyscarney
added a commit
that referenced
this pull request
May 14, 2020
…style individual options implements #17305
Member
|
I'm sorry it's taken so long for me to get back to this. I went ahead and implemented it on a new PR instead of trying to fix the conflicts with master: #21304 I added you as a co-author though so you still get the contribution: 5285824 This will go into our |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eable.
Short description of what this resolves:
Allows individual select options in a select popover to be styled separately.
Changes proposed in this pull request:
Ionic Version: 4.0.0