Warn about IonicPage Lifecycle#13250
Merged
Merged
Conversation
Warn IonicPage Lifecycle events are only available on IonicPage component, others components need Angular Lifecycle Hooks
Contributor
|
LGTM, will merge in a bit. |
Contributor
|
Thanks for the PR. Looks like this got lost in the shuffle. Merging. |
ChezRD
pushed a commit
to ChezRD/ionic
that referenced
this pull request
Jan 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warn IonicPage Lifecycle events are only available on IonicPage component, others components need Angular Lifecycle Hooks.
Short description of what this resolves:
In the NavController documentation, only Ionic Page Lifecycle events are present. At first, we have the impression that these events replace the Angular Lifecycle hooks, but that's not the case!
Changes proposed in this pull request:
Add warn
Ionic Version: 3