chore(docs): add anchor links to documentation sub-sections#12386
Merged
Conversation
perrygovier
previously requested changes
Jul 18, 2017
perrygovier
left a comment
Collaborator
There was a problem hiding this comment.
Can we make the title itself clickable as well, but have the styles stay the same until hover? This may require a CSS change in ionic-team/ionic-site
Author
|
Making the title not clickable was intentional because that's how the other sections (e.g. Usage, Instance Members) behave. Should I change it for those as well? |
Collaborator
|
Yeah, I think that's more the expected behavior these days. |
This was changed in the latest commit, with a related pull for a necessary style in ionic-site
perrygovier
approved these changes
Jul 18, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
This makes it possible to link to sub-sections of the markdown-generated API documentation on the website. In the past, users had to manually enter the hash in the URL if they wanted to do this.
Resolves ionic-team/ionic-site#1195, resolves ionic-team/ionic-site#689, resolves ionic-team/ionic-site#557
Changes proposed in this pull request:
<h3>tag and surrounds the entire thing with newlines.