Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
cb7d2f1
chore: use dev build
brandyscarney Jun 12, 2025
4a6ee9b
docs(reorder): update onIonItemReorder -> onIonReorderEnd
brandyscarney Jun 12, 2025
e11dbd5
style: lint
brandyscarney Jun 12, 2025
10e9ab0
fix(api): update the events table to include the deprecated description
brandyscarney Jun 12, 2025
6faa3bf
docs(reorder-group): add new interfaces and deprecate old ones
brandyscarney Jun 12, 2025
f99931c
chore: latest dev build
brandyscarney Jun 12, 2025
d9c35ec
fix(api): bold deprecated and move to its own line
brandyscarney Jun 12, 2025
5166f6e
docs(reorder): ionItemReorder -> ionReorderEnd
brandyscarney Jun 12, 2025
1b3b3ca
docs(reorder): set width of existing demos to 300px
brandyscarney Jun 13, 2025
2f597e8
docs(reorder): CustomEvent<ItemReorderEventDetail> -> ReorderEndCusto…
brandyscarney Jun 13, 2025
01f0b2e
docs(reorder): rename handleReorder functions to handleReorderEnd
brandyscarney Jun 13, 2025
5f901b4
style: lint
brandyscarney Jun 13, 2025
ce444b7
docs(reorder): add reorder-start-end playground
brandyscarney Jun 13, 2025
fa1e85b
style: comments and logs
brandyscarney Jun 13, 2025
e46a45e
docs(reorder): update reorder start end to set items data
brandyscarney Jun 13, 2025
15db739
docs(reorder): add reorder move playground
brandyscarney Jun 13, 2025
dc1311f
docs(reorder): update event handling descriptions and add logs
brandyscarney Jun 13, 2025
c0a6928
docs(reorder): rename playgrounds
brandyscarney Jun 13, 2025
6fe29a3
docs(reorder): copy editing
brandyscarney Jun 23, 2025
80b3a91
docs(reorder): copy editing
brandyscarney Jun 23, 2025
7ab2e2c
chore: revert dev build
brandyscarney Jun 23, 2025
e3ec9a6
style: lint
brandyscarney Jun 23, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
docs(reorder): update onIonItemReorder -> onIonReorderEnd
  • Loading branch information
brandyscarney committed Jun 23, 2025
commit 4a6ee9b50e69478d21909bc26eece0bf816f94ce
4 changes: 2 additions & 2 deletions docs/api/reorder-group.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ import Slots from '@ionic-internal/component-api/v8/reorder-group/slots.md';
import EncapsulationPill from '@components/page/api/EncapsulationPill';


The reorder group is a container for items using the [reorder](./reorder) component. When the user drags an item and drops it in a new position, the `ionItemReorder` event is dispatched. A handler for this event should be implemented that calls the `complete` method.
The reorder group is a container for items using the [reorder](./reorder) component. When the user drags an item and drops it in a new position, the `ionReorderEnd` event is dispatched. A handler for this event should be implemented that calls the `complete` method.

The `detail` property of the `ionItemReorder` event includes all of the relevant information about the reorder operation, including the `from` and `to` indexes. In the context of reordering, an item moves `from` an index `to` a new index. For example usage of the reorder group, see the [reorder](./reorder) documentation.
The `detail` property of the `ionReorderEnd` event includes all of the relevant information about the reorder operation, including the `from` and `to` indexes. In the context of reordering, an item moves `from` an index `to` a new index. For example usage of the reorder group, see the [reorder](./reorder) documentation.
Comment thread
brandyscarney marked this conversation as resolved.
Outdated


## Interfaces
Expand Down
2 changes: 1 addition & 1 deletion docs/api/reorder.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import EncapsulationPill from '@components/page/api/EncapsulationPill';

Reorder is a component that allows an item to be dragged to change its order within a group of items. It must be used within a [reorder group](./reorder-group) to provide a visual drag and drop interface.

The reorder is the anchor used to drag and drop the items. Once the reorder is complete, the `ionItemReorder` event will be dispatched from the reorder group and the `complete` method needs to be called.
The reorder is the anchor used to drag and drop the items. Once the reorder is complete, the `ionReorderEnd` event will be dispatched from the reorder group and the `complete` method needs to be called.


## Basic Usage
Expand Down
2 changes: 1 addition & 1 deletion static/demos/api/reorder/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@
function toggleReorder() {
const reorderGroup = document.getElementById('reorder');
reorderGroup.disabled = !reorderGroup.disabled;
reorderGroup.addEventListener('ionItemReorder', ({ detail }) => {
reorderGroup.addEventListener('ionReorderEnd', ({ detail }) => {
detail.complete(true);
});
}
Expand Down
2 changes: 1 addition & 1 deletion static/usage/v8/reorder/basic/react.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ function Example() {
return (
<IonList>
{/* The reorder gesture is disabled by default, enable it to drag and drop items */}
<IonReorderGroup disabled={false} onIonItemReorder={handleReorder}>
<IonReorderGroup disabled={false} onIonReorderEnd={handleReorder}>
<IonItem>
<IonLabel>Item 1</IonLabel>
<IonReorder slot="end"></IonReorder>
Expand Down
2 changes: 1 addition & 1 deletion static/usage/v8/reorder/custom-icon/react.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ function Example() {
return (
<IonList>
{/* The reorder gesture is disabled by default, enable it to drag and drop items */}
<IonReorderGroup disabled={false} onIonItemReorder={handleReorder}>
<IonReorderGroup disabled={false} onIonReorderEnd={handleReorder}>
<IonItem>
<IonLabel>Item 1</IonLabel>
<IonReorder slot="end">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ function Example() {
<div className="ion-content-scroll-host">
<IonList>
{/* The reorder gesture is disabled by default, enable it to drag and drop items */}
<IonReorderGroup disabled={false} onIonItemReorder={handleReorder}>
<IonReorderGroup disabled={false} onIonReorderEnd={handleReorder}>
<IonItem>
<IonLabel>Item 1</IonLabel>
<IonReorder slot="end"></IonReorder>
Expand Down
2 changes: 1 addition & 1 deletion static/usage/v8/reorder/toggling-disabled/react.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ function Example() {
return (
<>
<IonList>
<IonReorderGroup disabled={isDisabled} onIonItemReorder={handleReorder}>
<IonReorderGroup disabled={isDisabled} onIonReorderEnd={handleReorder}>
<IonItem>
<IonLabel>Item 1</IonLabel>
<IonReorder slot="end"></IonReorder>
Expand Down
2 changes: 1 addition & 1 deletion static/usage/v8/reorder/updating-data/react.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ function Example() {
return (
<IonList>
{/* The reorder gesture is disabled by default, enable it to drag and drop items */}
<IonReorderGroup disabled={false} onIonItemReorder={handleReorder}>
<IonReorderGroup disabled={false} onIonReorderEnd={handleReorder}>
{items.map((item) => (
<IonItem key={item}>
<IonLabel>Item {item}</IonLabel>
Expand Down
2 changes: 1 addition & 1 deletion static/usage/v8/reorder/wrapper/react.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ function Example() {
return (
<IonList>
{/* The reorder gesture is disabled by default, enable it to drag and drop items */}
<IonReorderGroup disabled={false} onIonItemReorder={handleReorder}>
<IonReorderGroup disabled={false} onIonReorderEnd={handleReorder}>
<IonReorder>
<IonItem>
<IonLabel>Item 1</IonLabel>
Expand Down