feat(playground): buttons now show tooltips#2234
Merged
Merged
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/ionic/ionic-docs/6orJSqkDy7JoG1KoU4ok7ZvE2oZU |
sean-perkins
approved these changes
Mar 16, 2022
Contributor
|
Ben's design for the tooltips is slightly different from this: https://www.figma.com/file/jykJRam54AGIOVZbQuxxqV/Ionic-Docs?node-id=0%3A1 Do we need to match that? |
Contributor
Author
|
I can match it |
Contributor
Author
|
All fixed. The tooltip styles were getting overridden so I made the selector more specific. Also the styles were referencing a CSS variable that was not defined. Tippy is added to the root of the page not as a child of the Playground. |
averyrousseau
approved these changes
Mar 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hovering over the source code, github, copy code, and stackblitz buttons now show tooltips.