Skip to content
This repository was archived by the owner on Mar 24, 2026. It is now read-only.

Integrate custom_lint#218

Merged
rrousselGit merged 2 commits intoinvertase:mainfrom
kuhnroyal:feature/custom-lint
Jan 19, 2024
Merged

Integrate custom_lint#218
rrousselGit merged 2 commits intoinvertase:mainfrom
kuhnroyal:feature/custom-lint

Conversation

@kuhnroyal
Copy link
Copy Markdown
Contributor

@kuhnroyal kuhnroyal commented Dec 21, 2023

Now that custom_lint supports JSON output, this action can finally be used to run and annotate custom lints 🎉
The feature is currently disabled by default.
If enabled, it will perform a pretty basic check for the existence of custom_lint: in the project before attempting to run.

Closes #199

@rrousselGit cc

@kuhnroyal
Copy link
Copy Markdown
Contributor Author

kuhnroyal commented Dec 21, 2023

The last Github action ran 9 month ago. I think the failing workflow is due to newer analyzer setting an exit code when encountering an error, or something like that.

Fixed

@kuhnroyal kuhnroyal marked this pull request as ready for review December 21, 2023 19:37
@rrousselGit
Copy link
Copy Markdown
Collaborator

cc @Salakar

@kuhnroyal
Copy link
Copy Markdown
Contributor Author

Would love a review here 👀

@rrousselGit
Copy link
Copy Markdown
Collaborator

I've been told that it's looking good for merge. Thanks for this!

@rrousselGit rrousselGit merged commit 3908581 into invertase:main Jan 19, 2024
@kuhnroyal kuhnroyal deleted the feature/custom-lint branch January 20, 2024 23:31
@kuhnroyal
Copy link
Copy Markdown
Contributor Author

Awesome, hope we can also get a release with this sometime :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run and annotate custom_lint if configured in project

2 participants