Repository navigation
Show the occupancy events in the activity log examples - #727
Draft
markdennis22 wants to merge 2 commits into
Draft
markdennis22 wants to merge 2 commits into
markdennis22 wants to merge 2 commits into
Conversation
In 2.16, 2.17 and Preview, add an admin_occupancy_state_change and an admin_occupancy_setting_change entry to the GET /admins/activity_logs and POST /admins/activity_logs/search response examples, so they show previous_state, new_state, threshold_minutes, last_activity_at, auto, setting_type and changes. The state change is recorded by the system, so its performed_by ip is `unknown`. The before and after values in activity_log_metadata.changes get an example each, and their descriptions say they take the setting's own type. They keep no `type`, because the value can be an integer, a boolean, a string or a list depending on the setting. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
In 2.14 and 2.15, add an admin_occupancy_state_change and an admin_occupancy_setting_change entry to the GET /admins/activity_logs response example, so it shows previous_state, new_state, threshold_minutes, last_activity_at, auto, setting_type and changes. The state change is recorded by the system, so its performed_by ip is `unknown`. The before and after values in activity_log_metadata.changes get an example each, and their descriptions say they take the setting's own type. They keep no `type`, because the value can be an integer, a boolean, a string or a list depending on the setting. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The activity log reference documents the
admin_occupancy_state_changeandadmin_occupancy_setting_changeevent types, but its response examples show neither. Thebeforeandaftervalues inchangesalso have no example. The 2.13 alignment PR fixed this for 2.13. This PR makes the same fix in the newer versions, and a companion PR makes it on developers.intercom.com, so the two references stay identical.How?
Adds one
admin_occupancy_state_changeentry and oneadmin_occupancy_setting_changeentry to theGET /admins/activity_logsresponse example. In versions that havePOST /admins/activity_logs/search, they go in its response example too. The system records the state change, so itsperformed_by.ipisunknown. Thebeforeandaftervalues inactivity_log_metadata.changeseach get an example, and their descriptions say they take the setting's own type. They have notype, because the value can be an integer, a boolean, a string or a list. Affects 2.14, 2.15, 2.16, 2.17 and Preview. The wording is the same as in 2.13.Notes for reviewers
created_atas the entries already in each example, as 2.13 does.Generated with Claude Code