This repository was archived by the owner on May 25, 2021. It is now read-only.
Update inrupt logo - #290
Merged
Merged
Conversation
Vinnl
approved these changes
Jun 26, 2020
Vinnl
left a comment
Contributor
There was a problem hiding this comment.
LGTM, might want to check your npm version and fix that if you used a different one than was specified though.
| "abbrev": { | ||
| "version": "1.1.1", | ||
| "resolved": false, | ||
| "resolved": "", |
Contributor
There was a problem hiding this comment.
Do you have nvm (or equivalent for your OS) set up to automatically switch to the right version? Because these changes look like they're caused by inconsistent npm versions. If that's because someone else used a different version than specified in .nvmrc then that's fine, but if it's because you used a different version, this will cause such noise and potentially conflicts in future PRs :)
Contributor
Author
There was a problem hiding this comment.
Yes, I'm on the node version on the .nvmrc with this commit - but likely wasn't last time I updated package-lock.json. 😬
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to latest inrupt logo.