Skip to content
This repository was archived by the owner on May 25, 2021. It is now read-only.

Fixing issue with idp-url login - #211

Merged
james-martin-jd merged 2 commits into
developfrom
feature/provider-login-entry
Apr 2, 2020
Merged

Fixing issue with idp-url login#211
james-martin-jd merged 2 commits into
developfrom
feature/provider-login-entry

Conversation

@james-martin-jd

@james-martin-jd james-martin-jd commented Apr 2, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Adding additional check to see if a file exists before attempting to use ldflex to get the oidc issuer. This is a workaround to the fact that if there is an HTTP error, like 404, then ldflex doesn't bubble the error up to us and the code halts. Now we only use ldflex if the file exists.

@james-martin-jd
james-martin-jd requested a review from NSeydoux April 2, 2020 15:15
@james-martin-jd
james-martin-jd merged commit 7ea9836 into develop Apr 2, 2020
@james-martin-jd
james-martin-jd deleted the feature/provider-login-entry branch April 2, 2020 15:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@NSeydoux NSeydoux NSeydoux approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@james-martin-jd @NSeydoux