This repository was archived by the owner on May 25, 2021. It is now read-only.
Fixed WebID login bug - #210
Merged
Merged
Conversation
The issue was that the login page made the assumption that the WebID was hosted on the same origin as the Identity Provider, which is not necessarily the case. This fix adds a check on the `solid:oidcIssuer` predicate in the Profile Document to get the Identity Provider address, while remaining backwards compatible by also testing the presence of the IdP at the WebID origin.
Vinnl
approved these changes
Apr 1, 2020
Vinnl
left a comment
Contributor
There was a problem hiding this comment.
There were two stray console.logs still left in. More importantly, unless I'm misunderstanding the code, it seems this is always firing off two HTTP requests when sometimes one would do? If not, it looks good to me.
Co-Authored-By: Vincent <Vinnl@users.noreply.github.com>
james-martin-jd
approved these changes
Apr 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue was that the login page made the assumption that the WebID was hosted on the same origin as the Identity Provider, which is not necessarily the case. This fix adds a check on the
solid:oidcIssuerpredicate in the Profile Document to get the Identity Provider address, while remaining backwards compatible by also testing the presence of the IdP at the WebID origin.