This repository was archived by the owner on May 25, 2021. It is now read-only.
FormModel tests - #207
Merged
Merged
Conversation
added 7 commits
March 9, 2020 14:35
…to tests/refactor-tests
Contributor
Author
|
The remaining failing tests are from the Shex components and custom hooks that were not part of the refactor. |
Several of the tests were failing for various reasons. These reasons include improper jest functions, incorrectly assumed structures, and using the wrong value property.
Contributor
|
Reviewed the tests - they look good. Adding some fixes to the other tests that are failing so all tests run successfully. |
Updated existing, older tests so that they render on each test. The sequential testing was causing issues with the render not being there as expected.
Re-render withAuthorization in each test
NSeydoux
reviewed
Mar 31, 2020
NSeydoux
left a comment
Collaborator
There was a problem hiding this comment.
Overall it looks all good, I just have a couple of questions that I left as comments where appropriate. Also, neither src/lib/components/FormModel/children/Spinner nor src/lib/components/FormModel/children/Viewer/UI/MultipleViewer include tests right now, is this an issue ?
NSeydoux
approved these changes
Apr 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On this PR:
testing-libraryto@testing-library/...devDependencies