Skip to content
This repository was archived by the owner on May 25, 2021. It is now read-only.

Refactor the form renderer in edit mode - #184

Merged
angelaraya merged 6 commits into
developfrom
refactor/forms-edit
Jan 10, 2020
Merged

Refactor the form renderer in edit mode#184
angelaraya merged 6 commits into
developfrom
refactor/forms-edit

Conversation

@angelaraya

Copy link
Copy Markdown
Contributor

Components in this refactor:

Decimal Field
SingleLine
Text Area
Float
Email
Phone
BoolLine
RadioButton
Integer
ColorPicker
CleanUp

Refactor Decimal Field
Refactor SingleLine
Refactor Text Area
Refactor Float
Refactor Email

Refactor Phone
Refactor BoolLine
Refactor RadioButton
Refactor Integer
Refactor ColorPicker
Refactor CleanUp
Comment thread src/lib/components/FormModel/form-model.component.js Outdated
Comment thread src/lib/components/FormModel/children/Form/UI/Email/index.js Outdated
Comment thread src/lib/components/FormModel/children/Form/UI/Integer/index.js Outdated
Comment thread src/lib/components/FormModel/children/Form/UI/Phone/index.js Outdated
Comment thread src/lib/components/FormModel/children/Form/UI/RadioButton/index.js
import BoolLine from './BoolLine';
import { BoolLine } from './BoolLine';
import ColorLine from './ColorLine';
import Heading from '../../Form/UI/Heading';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are Heading/Comment no longer in the Viewer, or is it generated another way?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think when we spoke yesterday we determined this file isn't actually used anymore?

Comment thread src/lib/components/FormModel/form-reducers.js Outdated
Comment thread src/lib/components/FormModel/index.js
Comment thread src/lib/components/index.js Outdated
Comment thread src/lib/index.js
Comment thread src/lib/components/FormModel/children/Multiple/multiple.component.js Outdated
@angelaraya
angelaraya marked this pull request as ready for review January 10, 2020 16:44
@angelaraya
angelaraya merged commit 70e48ab into develop Jan 10, 2020
@angelaraya
angelaraya deleted the refactor/forms-edit branch January 10, 2020 16:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants