Repository navigation
Pick up VC Provider from environment configuration - #530
Merged
Merged
Conversation
NSeydoux
marked this pull request as ready for review
June 14, 2023 13:04
acoburn
approved these changes
Jun 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enforces that the integration tests in CI run against live services rather than running against mocks.
Note to reviewers: I'm not sure about the misalignment between the repo secret and the config variable names. Should the secret be namedI actually went ahead and opened addressed this with f4b2080.INRUPT_DEV_VC_PROVIDER(resp.PROD), or should we change the config var frominrupt.test.vc.providertoinrupt.test.access.grant.issuer? I think the latter makes more sense, considering VCs should be an implementation detail of access grants rather than something more front and center.