Repository navigation
JCL-337: End-to-end test of UMA auth for Access Grants endpoints - #520
Merged
Merged
Conversation
NSeydoux
force-pushed
the
JCL-337_access-grants-e2e
branch
3 times, most recently
from
June 12, 2023 16:23
061ac9e to
a6e632a
Compare
The OpenID session was disregarding the provided authenticator, resulting in only ever using the ID Token as an Access Token instead of using the ID Token as a credential to get an UMA-issued Access Token. If no authenticator is provided, use the ID Token as an Access Token.
- Extend base test suite with an UMA-specific scenario verifying that UMA authentication is enforced. - Enable caching in tests - Enable UMA auth to mock VC issuer
NSeydoux
force-pushed
the
JCL-337_access-grants-e2e
branch
from
June 12, 2023 16:29
a6e632a to
8df11be
Compare
This checks that the appropriate authenticator is being used in OpenID-specific tests
NSeydoux
force-pushed
the
JCL-337_access-grants-e2e
branch
from
June 12, 2023 16:34
8df11be to
1654225
Compare
acoburn
reviewed
Jun 12, 2023
| import org.jose4j.lang.UncheckedJoseException; | ||
|
|
||
| final class Utils { | ||
| public final class Utils { |
Contributor
There was a problem hiding this comment.
If we're making this public, should we also make the other fields public? (That could also be a follow-on PR to keep this one simpler)
Contributor
Author
There was a problem hiding this comment.
There's no reason not to, and it would probably look more consistent. I'll open a follow-up PR.
NSeydoux
added a commit
that referenced
this pull request
Jun 12, 2023
This follows up from #520, and updates the integration test utils so that all fields are public for consistency.
NSeydoux
added a commit
that referenced
this pull request
Jun 12, 2023
This follows up from #520, and updates the integration test utils so that all fields are public for consistency.
NSeydoux
marked this pull request as ready for review
June 12, 2023 22:17
NSeydoux
added a commit
that referenced
this pull request
Jun 13, 2023
This follows up from #520, and updates the integration test utils so that all fields are public for consistency.
NSeydoux
added a commit
that referenced
this pull request
Jun 13, 2023
This follows up from #520, and updates the integration test utils so that all fields are public for consistency.
acoburn
pushed a commit
that referenced
this pull request
Jun 13, 2023
This follows up from #520, and updates the integration test utils so that all fields are public for consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds tests to verify that the expected authentication mechanism (UMA or OpenId) gets used when accessing the Access Grants endpoints (e.g.
/issue)