Skip to content

JCL-366: Address sonar warnings for access grant module - #487

Merged
acoburn merged 3 commits into
mainfrom
JCL-366-sonar-access-grants
May 26, 2023
Merged

acoburn merged 3 commits into
mainfrom
JCL-366-sonar-access-grants

Conversation

@acoburn

@acoburn acoburn commented May 25, 2023

Copy link
Copy Markdown
Contributor

This addresses a few different sonar warnings about the access grant module:

  • providing parameterized types for generics
  • defining constants for literals
  • reducing cognitive complexity of a certain method

The Map objects are derived from JSON structures, so they will always have the Map<String, Object> type.

@acoburn
acoburn requested a review from a team May 25, 2023 19:14
@acoburn
acoburn enabled auto-merge (squash) May 26, 2023 10:19
@acoburn
acoburn merged commit 1a02048 into main May 26, 2023
@acoburn
acoburn deleted the JCL-366-sonar-access-grants branch May 26, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants