Repository navigation
JCL-350: Better use of GH Environments for CI/CD workflows - #457
Merged
Merged
Conversation
timea-solid
reviewed
May 16, 2023
timea-solid
left a comment
Contributor
There was a problem hiding this comment.
Observations I see:
- pod or dev the CI runs both java 11 and 17
- dev CIs will be gating now
Contributor
Author
If you look closely at the condition statement, dev only runs with java 11 and it isn't gating (failures are tolerated) |
timea-solid
approved these changes
May 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GH includes the use of "Environments" for use with CI/CD workflows. These environments are intended to be used as deployment targets, but we are currently using this as a way to partition configuration secrets. This adjusts the CI/CD structure to align our use of environments with the intended use, namely deployment targets.
Note: Before merging, this will require adjusting the branch protection rules