This repository was archived by the owner on Oct 29, 2024. It is now read-only.
Fix issue 237#244
Closed
geodimm wants to merge 2 commits into
Closed
Conversation
The methods switch_database and switch_user are supposed to be called on all clients in the cluster, not just a random one.
Contributor
|
seems totally legit to me, so +1 :) |
Contributor
Author
|
Hi, |
Collaborator
|
Thank you @georgijd |
4b91f24 to
65292f2
Compare
Contributor
Author
|
Hey guys, sorry for the delay, it's been a busy week :) |
Collaborator
|
@georgijd Can you transfer this onto this PR? |
Collaborator
|
As far as I understand, this is fixed in #253 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should enable the cluster client to properly switch databases and user credentials for all clients in the cluster, not just a random one. It doesn't look pretty and actually I'd like to suggest an alternative implementation of the InfluxDBClusterClient which will actually inherit the InfluxDBClient and instead of maintaining a list of InfluxDBClients, we can just keep the list of (host, port) tuples and alternate those on each request. This way we win a few things:
Since some users of the library might be using the
clientsattribute of the cluster client current implementation, we can make the new one backwards compatible by having a list with only one element (self) as theclientsattribute, i.e.self.clients = [self]@aviau , @gst, @areski , any thoughts on that?