Skip to content

fix: duplicated debug output#521

Merged
powersj merged 2 commits into
masterfrom
fix-duplicate-logging-handler
Oct 21, 2022
Merged

fix: duplicated debug output#521
powersj merged 2 commits into
masterfrom
fix-duplicate-logging-handler

Conversation

@bednar

@bednar bednar commented Oct 21, 2022

Copy link
Copy Markdown
Contributor

Closes #519

Proposed Changes

The logging.StreamHandler(sys.stdout) should appended only once into Logger.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@bednar
bednar marked this pull request as ready for review October 21, 2022 08:24
@bednar
bednar requested a review from powersj October 21, 2022 08:26

@powersj powersj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you! Let's wait for the reporter to confirm to merge.

@powersj
powersj merged commit d4f7df9 into master Oct 21, 2022
@powersj
powersj deleted the fix-duplicate-logging-handler branch October 21, 2022 18:49
@bednar bednar added this to the 1.34.0 milestone Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiplying output with every request

2 participants