Defining when an opaque framebuffer is considered dirty#970
Merged
Conversation
cabanier
approved these changes
Mar 4, 2020
Member
cabanier
left a comment
There was a problem hiding this comment.
The "...but only if..." section of the sentence is a bit hard to read but otherwise this looks good to me
Member
Author
|
Just realized that this /fixes #877 |
Manishearth
approved these changes
Mar 5, 2020
Contributor
Manishearth
left a comment
There was a problem hiding this comment.
r? @asajeffrey as well
|
LGTM FWIW |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cribs very directly from the equivalent WebGL spec text, with appropriate verbiage changes. Related to #969, but doesn't actually fix that one since the issue itself is more about what happens when the users doesn't dirty the framebuffer for a while.