Check whether a session is inline rather than immersive when appropriate#834
Merged
toji merged 1 commit intoimmersive-web:masterfrom Sep 10, 2019
Merged
Check whether a session is inline rather than immersive when appropriate#834toji merged 1 commit intoimmersive-web:masterfrom
toji merged 1 commit intoimmersive-web:masterfrom
Conversation
For steps that are really related to inline sessions, check that directly for clarity. This also avoids needing to consider things like immersive-web#817 for these steps.
ddorwin
commented
Sep 6, 2019
| 1. If |type| is {{local}} or {{local-floor}}, and |session| is an [=immersive session=], return <code>true</code>. | ||
| 1. If |type| is {{local}} or {{local-floor}}, and the [=XRSession/XR device=] supports reporting orientation data, return <code>true</code>. | ||
| 1. If |type| is {{bounded-floor}} and |session| is an [=immersive session=], return if [=bounded reference spaces are supported=] by the [=XRSession/XR device=]. | ||
| 1. If |type| is {{bounded-floor}} and |session| is an [=immersive session=], return the result of whether [=bounded reference spaces are supported=] by the [=XRSession/XR device=]. |
Contributor
Author
There was a problem hiding this comment.
Another way to phrase this is "the result of executing the Foo algorithm." However, that doesn't seem consistent with how the algorithms are referenced in this spec.
Manishearth
approved these changes
Sep 6, 2019
Member
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For steps that are really related to inline sessions, check that directly for clarity.
This also avoids needing to consider things like #817 for these steps.