Simplify handling of unsupported modes in requestSession()#714
Merged
toji merged 1 commit intoimmersive-web:masterfrom Jun 17, 2019
Merged
Simplify handling of unsupported modes in requestSession()#714toji merged 1 commit intoimmersive-web:masterfrom
toji merged 1 commit intoimmersive-web:masterfrom
Conversation
After immersive-web#685, there is only one failure path at this point, and these steps can be simplified. This also addresses incorrectly rejecting with `null`.
Manishearth
approved these changes
Jun 17, 2019
| 1. Follow the steps for the first matching conditions: | ||
| <dl class="switch"> | ||
| <dt> If the [=XR/XR device=] is <code>null</code> | ||
| <dd> [=Reject=] |promise| with <code>null</code>. |
Contributor
There was a problem hiding this comment.
Do we want to lose this distinction between promises rejected as null and notsupported? I don't think it's important.
Member
There was a problem hiding this comment.
I don't think it's an important distinction either. I can't imagine that a developer is going to do anything useful with that knowledge besides maybe fingerprinting.
Member
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #685, there is only one failure path at this point, and these steps can be simplified.
This also addresses incorrectly rejecting with
null.