Merged
Conversation
Also changed `baseLayer` to only accept an `XRWebGLLayer`. This can be extended in the future in a few ways: - Re-introduce XRLayer and change `baseLayer` to take one. - Update `baseLayer` to accept a union of layer types. - Leave `baseLayer` as WebGL-only and enforce that new layer types must use whatever layer array mechanism is introduced.
Manishearth
approved these changes
Jun 10, 2019
NellWaliczek
approved these changes
Jun 10, 2019
Member
NellWaliczek
left a comment
There was a problem hiding this comment.
LGTM. Just have a few nits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/fixes #268
Also changed
baseLayerto only accept anXRWebGLLayer. This can beextended in the future in a few ways:
baseLayerto take one.baseLayerto accept a union of layer types.baseLayeras WebGL-only and enforce that new layer types mustuse whatever layer array mechanism is introduced.