Edit requestSession() and Initialize the session#601
Merged
toji merged 1 commit intoimmersive-web:masterfrom Apr 23, 2019
Merged
Edit requestSession() and Initialize the session#601toji merged 1 commit intoimmersive-web:masterfrom
toji merged 1 commit intoimmersive-web:masterfrom
Conversation
This change fixes strings to the XRSessionMode values, uses the same format for DOMExceptions, and makes the Initialize the session algorithm more explicit by defining parameters to it. This does not have any behavioral change.
Manishearth
approved these changes
Apr 22, 2019
Contributor
Manishearth
left a comment
There was a problem hiding this comment.
Yeah, most other specs very carefully separate attributes ({{XRSession/mode}}) from the internal parameters (|mode|) they reflect, I was surprised that this wasn't being done here. I definitely support moving closer towards this model for this spec, it's much easier to evolve spec-wise.
Member
|
Thank you very much. |
Contributor
Author
|
Thanks for reviewing and merging this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes strings to the XRSessionMode values, uses the same format for
DOMExceptions, and makes the Initialize the session algorithm more explicit by
defining parameters to it. This does not have any behavioral change.