Rename supportsSessionMode to supportsSession#595
Merged
Conversation
NellWaliczek
approved these changes
Apr 19, 2019
Member
NellWaliczek
left a comment
There was a problem hiding this comment.
LGTM. I'd always sort of preferred this naming anyway ;)
| </div> | ||
|
|
||
| Calling {{XR/supportsSessionMode()}} MUST NOT trigger device-selection UI as this would cause many sites to display XR-specific dialogs early in the document lifecycle without user activation. | ||
| Calling {{XR/supportsSession()}} MUST NOT trigger device-selection UI as this would cause many sites to display XR-specific dialogs early in the document lifecycle without user activation. Additionally, calling {{XR/supportsSession()}} MUST NOT interfere with any running XR applications on the system. |
Member
There was a problem hiding this comment.
Good catch that this didn't make it over from the explainer. We should probably also make it clear that this should not cause any other applications to launch on the system such as SteamVR.
Fixes #592. Brings name inline with requestSession, which now takes the same arguments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #592. Brings name inline with requestSession, which now takes the
same arguments.
This is a simple enough change that I figured I'd just have a PR ready to go if we agree with #592.