Remove attribs that only reflect requested values#574
Merged
Conversation
Member
Author
|
Nell requested that I split out the attribs and reference space bits of this PR, which I'm fine with. I'll get to that sometime in the next week or so. |
Member
Author
|
Separated changes as requested. Reference space consolidation is now handled in #587. |
NellWaliczek
suggested changes
Apr 16, 2019
Member
NellWaliczek
left a comment
There was a problem hiding this comment.
Minor feedback... I'm generally supportive of this change
Member
Author
|
Feedback addressed. Take one more look? |
Member
Author
|
Rebased. Review ping, @NellWaliczek? |
NellWaliczek
approved these changes
Apr 19, 2019
Member
NellWaliczek
left a comment
There was a problem hiding this comment.
Let's make sure the final commit title reflects which types we actually cleaned up, but other than that LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #513
Addresses some discussion in #514, but doesn't change the enums.
This PR removes the
modeattrib fromXRSession, thedepth,stencil, andalphaattribs fromXRWebGLLayer, and thesubtypeattrib fromXRStationaryReferenceSpace. Since that leftXRStationaryReferenceSpacewith nothing else in it, I also took the opportunity to consolidate it andXRUnboundedReferenceSpaceintoXRReferenceSpace.