During requestAnimationFrame detect if session has ended#1169
Merged
Manishearth merged 2 commits intoimmersive-web:mainfrom Feb 3, 2021
cabanier:invalid-raf
Merged
During requestAnimationFrame detect if session has ended#1169Manishearth merged 2 commits intoimmersive-web:mainfrom cabanier:invalid-raf
Manishearth merged 2 commits intoimmersive-web:mainfrom
cabanier:invalid-raf
Conversation
Merge with main repo
Member
Author
Manishearth
approved these changes
Feb 3, 2021
Contributor
Manishearth
left a comment
There was a problem hiding this comment.
r=me but remove index.html
| @@ -0,0 +1,8811 @@ | |||
| <!doctype html><html lang="en"> | |||
Contributor
There was a problem hiding this comment.
don't check in index.html
Member
Author
There was a problem hiding this comment.
I'm used to adding it to .gitignore :-)
Member
Author
|
@Manishearth I removed index.html |
toji
reviewed
Feb 5, 2021
Member
toji
left a comment
There was a problem hiding this comment.
Post-merge LGTM, for what it's worth. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview | Diff