Skip to content

Implicit jackson config #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iluxa-test wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Implicit jackson config #1

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
bb98ce2
Replace static ObjectMappers with DockerClientConfig#getObjectMapper
bsideup Nov 19, 2019
2c6002e
remove unused `ObjectMapper` field
bsideup Nov 19, 2019
79c3608
revert change
bsideup Nov 19, 2019
cd11cf9
simplify AbstrDockerCmdExec
bsideup Nov 19, 2019
05b4f29
Merge branch 'master' into implicit_jackson_config
bsideup Nov 20, 2019
e9ccbed
Remove unnecessary Jackson annotations
bsideup Nov 20, 2019
1171555
Remove `anUnconfiguredCommandSerializesToEmptyJson` test case
bsideup Nov 20, 2019
72990a2
Try to disable the parallel test execution
bsideup Nov 20, 2019
eebb9ff
Add more logging, try just "hello"
bsideup Nov 20, 2019
1aa68fa
Revert the parallel change
bsideup Nov 20, 2019
0522a79
Back to sequential tests :(
bsideup Nov 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove anUnconfiguredCommandSerializesToEmptyJson test case
  • Loading branch information
@bsideup
bsideup committed Nov 20, 2019
commit 1171555a6b2454ee584f2aa68a34682d2b126ba6
8 changes: 0 additions & 8 deletions docker-java/src/test/java/com/github/dockerjava/cmd/StartContainerCmdIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

import com.github.dockerjava.api.command.CreateContainerResponse;
import com.github.dockerjava.api.command.InspectContainerResponse;
import com.github.dockerjava.api.command.StartContainerCmd;
import com.github.dockerjava.api.exception.DockerException;
import com.github.dockerjava.api.exception.InternalServerErrorException;
import com.github.dockerjava.api.exception.NotFoundException;
Expand All @@ -16,7 +15,6 @@
import com.github.dockerjava.api.model.Volume;
import com.github.dockerjava.api.model.VolumesFrom;
import com.github.dockerjava.core.command.WaitContainerResultCallback;
import com.github.dockerjava.test.serdes.JSONTestHelper;
import net.jcip.annotations.NotThreadSafe;
import org.junit.Test;
import org.slf4j.Logger;
Expand Down Expand Up @@ -570,10 +568,4 @@ public void existingHostConfigIsPreservedByBlankStartCmd() throws DockerExceptio
assertThat(inspectContainerResponse.getHostConfig().getDns(), is(notNullValue()));
assertThat(Arrays.asList(inspectContainerResponse.getHostConfig().getDns()), contains(dnsServer));
}

@Test
public void anUnconfiguredCommandSerializesToEmptyJson() throws Exception {
StartContainerCmd command = dockerRule.getClient().startContainerCmd("");
assertThat(JSONTestHelper.getMapper().writeValueAsString(command), is("{}"));
}
}