Skip to content

#496 Pipeline pattern#967

Merged
iluwatar merged 7 commits into
iluwatar:masterfrom
jjjimenez100:master
Oct 8, 2019
Merged

#496 Pipeline pattern#967
iluwatar merged 7 commits into
iluwatar:masterfrom
jjjimenez100:master

Conversation

@jjjimenez100
Copy link
Copy Markdown
Contributor

@iluwatar
Copy link
Copy Markdown
Owner

iluwatar commented Oct 7, 2019

@jjjimenez100 the build is failing due to PMD error. See https://travis-ci.org/iluwatar/java-design-patterns/builds/594261640

@jjjimenez100
Copy link
Copy Markdown
Contributor Author

Hi @iluwatar. Sorry about that, this is actually my first PR with a repo having checkstyle and PMD.
I tried running mvn pmd:pmd pmd:cpd on the pipeline directory I did to try and correct errors it reported. Hopefully this will have a successful build now 👌

Comment thread pipeline/README.md Outdated
Comment thread pipeline/README.md Outdated
@iluwatar iluwatar added this to the 1.22.0 milestone Oct 8, 2019
@iluwatar iluwatar merged commit f903d7e into iluwatar:master Oct 8, 2019
@iluwatar
Copy link
Copy Markdown
Owner

iluwatar commented Oct 8, 2019

Thanks @jjjimenez100, beautiful pattern and well implemented 👍

@oconnelc
Copy link
Copy Markdown
Contributor

I don't know if this is related, but the pipeline project is failing to compile for me because of the project hierarchy.

It's currently:

src/main/java/com.iluwatar.pipeline/*.java

I think it should be:
src/main/java/com/iluwatar/pipeline/*.java

@oconnelc
Copy link
Copy Markdown
Contributor

Also I have a commit that I can push up as a PR.

@iluwatar
Copy link
Copy Markdown
Owner

@oconnelc please create an issue about the problem, and then the PR that fixes this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants