Fix for issue #954 : Add external Dependencies to run with Java11#957
Merged
Conversation
Add javax.annotation and java.xml.bind as external maven dependencies Verified with jdk-11
iluwatar
requested changes
Oct 6, 2019
iluwatar
approved these changes
Oct 6, 2019
Owner
|
Thanks @jarpit96 for resolving this issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
JAXB API and javax.Annotations were removed from jdk11, so some tests were failing.
Changes:
Add javax.annotation and java.xml.bind as external maven dependencies
Verification:
Verified tests with jdk-11