Refactor Page-object pattern#812
Merged
Merged
Conversation
iluwatar
approved these changes
Oct 24, 2018
Owner
|
Thanks @staillebois 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor page-object
Pull request description :
Create 2 Sub modules such as in the initial commit from @colinbut :
The second commit was to replace e.printStackTrace with a Logger like recommanded by Sonar.
PS : I update the root pom.xml to remove the scope "test" under net.sourceforge.htmlunit because now we need it for the test-automation src/main folder.