Skip to content

Refactor Page-object pattern#812

Merged
iluwatar merged 2 commits into
iluwatar:masterfrom
staillebois:pageObject
Oct 24, 2018
Merged

Refactor Page-object pattern#812
iluwatar merged 2 commits into
iluwatar:masterfrom
staillebois:pageObject

Conversation

@staillebois
Copy link
Copy Markdown
Contributor

Refactor page-object

Pull request description :

  • Create 2 Sub modules such as in the initial commit from @colinbut :

    • sample-application : that represents the sample application under test.
    • test-automation : that represents the test project which tests that sample application
  • The second commit was to replace e.printStackTrace with a Logger like recommanded by Sonar.

PS : I update the root pom.xml to remove the scope "test" under net.sourceforge.htmlunit because now we need it for the test-automation src/main folder.

@iluwatar iluwatar merged commit 1f1fcae into iluwatar:master Oct 24, 2018
@iluwatar
Copy link
Copy Markdown
Owner

Thanks @staillebois 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants