Captain is implementing RowingBoat - Adapter pattern#723
Merged
Conversation
Captain and RowingBoat aren't interchangable. Captain, as a client, may have a method to use the boat, but it isn't needed that they share the same interface, as it makes the code more confusing.
iluwatar
requested changes
Mar 7, 2018
Owner
iluwatar
left a comment
There was a problem hiding this comment.
The compilation fails with [ERROR] /home/travis/build/iluwatar/java-design-patterns/adapter/src/main/java/com/iluwatar/adapter/Captain.java:[43,3] method does not override or implement a method from a supertype
My bad, sorry. It should compile now.
Contributor
Author
|
It should be working now. |
iluwatar
approved these changes
Mar 11, 2018
Owner
|
Thanks @juaanma for this improvement 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Captain and RowingBoat aren't interchangable.
Captain, as a client, may have a method to use the boat, but it isn't needed that they share the same interface, as it makes the code more confusing.