Remove redundant explicit super()#695
Closed
jonatasemidio wants to merge 1 commit into
Closed
Conversation
Remove redundant explicit super() constructor calls [iluwatar#694](iluwatar#694)
Contributor
|
I think there are a few more occurrences of |
Author
|
Hi @olcbean is totally fine, but now I need to check if it is necessary because @james-a-roland created another and more complete PR (#697). @iluwatar, another consideration... I know that grep can find all occurrences, but we might have some samples that super() calls some father's constructors. Hi @james-a-roland, To solve #694 ... How did you checked all super() occurrences? |
Author
|
Sorry @iluwatar and @james-a-roland... You don't need to answer here because I've already add the last comment in the right discussion #694 |
iluwatar
requested changes
Jan 13, 2018
iluwatar
left a comment
Owner
There was a problem hiding this comment.
The pull request seems incomplete. There are many other occurrences.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove redundant explicit super() constructor calls #694
Remove redundant explicit super() constructor
The super() calls (taking no arguments) are inserted during compile time, so just make the code more verbose than required.