fixed issue #681#693
Conversation
iluwatar
left a comment
There was a problem hiding this comment.
The picture looks good but you shouldn't delete the corresponding project file abstract-document.ucls
|
@iluwatar The abstract-document.ucls is a xml file to generate UML picture, because they will generate wrong UML picture if keep old UCLS files, besides, I'm using another UML tool which cannot generate such a file. I could download the plugin and repaint the UML with UCLS file if you really need it. |
|
You should include the updated |
|
okay. |
jujis008
left a comment
There was a problem hiding this comment.
i've regenerate the UML diagram with UCLS files, please kindly approve.
iluwatar
left a comment
There was a problem hiding this comment.
abstract-document.ucls was added 👍 but now you have deleted abstract-document.png and added abstract-documents.png. Also README.md should be updated with the new links.
|
Aha, that's my bad. Already commit the changes, thanks a lot you point out the mistakes. |
|
Thanks for fixing this @jujis008 😄 |
fixed the diagram bug and merge two pictures as one
As reporter says there has one error on the diagram, I've repaint the UML diagram and merge them together which make it clean and clear.
Pull request description
fixed the error and deleted unrelation pictures and files