#66 Balking Pattern#536
Merged
Merged
Conversation
iluwatar
reviewed
Jan 22, 2017
Owner
iluwatar
left a comment
There was a problem hiding this comment.
- The balking module is missing from the parent pom.xml
- The compilation is failing due to Checkstyle issue
iluwatar
requested changes
Jan 22, 2017
Owner
iluwatar
left a comment
There was a problem hiding this comment.
@Rzeposlaw you have my review comments. Please comment when you've addressed the findings.
| import java.util.concurrent.ExecutorService; | ||
| import java.util.concurrent.Executors; | ||
| import java.util.concurrent.TimeUnit; | ||
|
|
Owner
There was a problem hiding this comment.
Please describe the pattern and how the example implements it here in the comments
| package com.iluwatar.balking; | ||
|
|
||
| public class AppTest { | ||
| @org.junit.Test |
Owner
There was a problem hiding this comment.
Nitpicking, but here import org.junit.Test and @test annotation would be better.
Owner
|
@Rzeposlaw any updates on this? The pull request is about to expire. |
Contributor
Author
|
Hello, I'm sorry, I was busy. Today I will send the updated version. :) |
Contributor
Author
|
@iluwatar I'm ready for another review. :) |
iluwatar
approved these changes
Mar 26, 2017
Owner
|
@Rzeposlaw looks good, thank you for the pattern contribution 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for Balking Pattern issue #66