Coverage decreased (-0.08%) to 84.217% when pulling eea8785 on dmitraver:master into 4ca205c on iluwatar:master.

@iluwatar

Hi! Please review once you have a time ;)

Yeah, I reread it also after a while and it doesn't ring a bell. I will make a change today and update my PR. Thanks.

On 17 Oct 2016, at 22:15, Ilkka Seppälä notifications@github.com wrote:

@iluwatar requested changes on this pull request.

I would rephrase this sentence: "Limits object composability by stopping the clients to specify needed dependencies for different objects instantiation." To be honest, I don't know what it means.

I would like to add more consequences to Singleton. 1) Creates tightly coupled code that is difficult to test 2) It's almost impossible to subclass a Singleton

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@iluwatar I addressed your points. I removed the phrase that causes confusion cause its an edge case of singleton usage and its already described better in other two points. What do you think?

Coverage decreased (-1.2%) to 83.079% when pulling b66e8ec on dmitraver:master into 4ca205c on iluwatar:master.

@dmitraver looks good now. Thanks for your contribution!